Skip to content

London | 26-ITP-SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests - #1700

Open
russom-g wants to merge 72 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-2-implement-and-rewrite
Open

London | 26-ITP-SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests#1700
russom-g wants to merge 72 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-2-implement-and-rewrite

Conversation

@russom-g

@russom-g russom-g commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

Functions implemented. Tests written with node and jest.

russom added 30 commits September 28, 2026 14:46
russom
List edge cases for test.
301ea63
russom
Update list.
2501561
russom
Add an if condition to check midnight
63e477b
russom
Add another case to test midnight
a8e1b2d
russom
Add test case 00:01 to 12:01 am
9e2cef8
russom
Add condition for checking midday 12 pm
2ba2e34
russom
Add test case for 01:00 to 01:00 am
06d5f91
russom
Add test case for 11:59 to 11:59 am
3dc6da6
russom
Add test case for 12:01 to 12:01 pm
1e6cb55
russom
Add test case for 13:00 to 1:00 pm
61b2ce7
russom
Add test case fo 23:59 to 11:59 pm
0407869
russom
Add padStart method to hours
06d3f9a
russom
Add more description.
598f744
russom
Add padStart method to convert 23:00 to 01:00pm
e6fde3b
russom
Edit comments
c2f743c
russom
Inline code directly into return statement
e7ff9c7
russom
Change am and pm to lower case and update description.
751fb78
russom
Unreachable code.
4707f5a
russom
Remove unreachable and redundant code.
f504687
russom
Remove unused code
d9197c4
russom
Update function to work for any input.
9494c3d
russom
Format code with prettier.
582699c
russom
Stop tracking files
b806b41
russom
Stop tracking files
fcf27e7
russom
Restore files unrelated to this PR
04f544f
russom
Add if condition for checking right angle.
4815e87
russom
Write test for Acute angle.
9dc9e1f
russom
Write test for Obtuse angle.
10b0d0f
russom
Add if condition for checking Acute angle.
cccf002
russom
Add if condition for checking Obtuse angle.
ed2729e
@hackertainment hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026
@hackertainment hackertainment mentioned this pull request Oct 19, 2026
Open
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 19, 2026
@hackertainment

hackertainment commented Oct 20, 2026

Copy link
Copy Markdown

Thank you for your effort. You are almost there, and just remain the following new comments:

@hackertainment hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026
@russom-g russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 22, 2026
@russom-g russom-g changed the title London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests London | 26-ITP-SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests Oct 22, 2026
@hackertainment

hackertainment commented Oct 22, 2026

Copy link
Copy Markdown

For the following two comments, has the test case (-3, -7) been added and does the program return true? If not, how to fix the program?

@hackertainment hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 22, 2026
@russom-g russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 23, 2026
@hackertainment

hackertainment commented Oct 23, 2026

Copy link
Copy Markdown

It's correct now. In the future, focus more on minimum number of test cases with maximum coverage of scenarios. You may plan the test combinations in English first and write the testing code based on the plan. Please book a mentored coding session with a volunteer and learn more on test cases design process. This PR has been completed. Thank you.

@hackertainment hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hackertainment hackertainment hackertainment left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russom-g @hackertainment